Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteSpawnRunner: record inbetween phases in timing profile #20387

Closed
wants to merge 2 commits into from
Closed

RemoteSpawnRunner: record inbetween phases in timing profile #20387

wants to merge 2 commits into from

Commits on Dec 7, 2023

  1. RemoteSpawnRunner: record inbetween phases in timing profile 

    After an action was executed remotely, RemoteSpawnRunner would use
the timestamps in the execution metadata to record appropriate timing
phases into the JSON profile.

However, there are durations in-between the existing phases that are
unaccounted for. Depending on the RBE server implemenation, these
phases could mean different things:
- Sandbox preparation
- Cleaning up sandbox environments post-execution
- Others

Missing these durations inside the timing profile would cause confusion
to end users as it would be interpreted as nothing happened in between
the existing phases.

Add these durations into the profile as "pre-X" phases so that user is
aware of activities could still be happening during that time. RBE
server implementation should be able to alter these label
programmatically if necessary.
    @sluongng
    sluongng committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4f4de83 View commit details
    Browse the repository at this point in the history

  2. Make use of FETCH, use REMOTE_SETUP for generic phases

    @sluongng
    sluongng committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    680fdc9 View commit details
    Browse the repository at this point in the history