Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] RemoteSpawnRunner: record inbetween phases in timing profile #20647

Merged
merged 3 commits into from
Jan 11, 2024

Commits on Dec 21, 2023

  1. RemoteSpawnRunner: record inbetween phases in timing profile

    After an action was executed remotely, RemoteSpawnRunner would use
    the timestamps in the execution metadata to record appropriate timing
    phases into the JSON profile.
    
    However, there are durations in-between the existing phases that are
    unaccounted for. Depending on the RBE server implemenation, these
    phases could mean different things:
    - Sandbox preparation
    - Cleaning up sandbox environments post-execution
    - Others
    
    Missing these durations inside the timing profile would cause confusion
    to end users as it would be interpreted as nothing happened in between
    the existing phases.
    
    Add these durations into the profile as "pre-X" phases so that user is
    aware of activities could still be happening during that time. RBE
    server implementation should be able to alter these label
    programmatically if necessary.
    
    Closes bazelbuild#20387.
    
    PiperOrigin-RevId: 590816782
    Change-Id: I2bee36be928db24a14fab18bc519c3893723b7d6
    sluongng authored and bazel-io committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    8a74f2f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    4fb2273 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    6e10846 View commit details
    Browse the repository at this point in the history