Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] DigestUtils: avoid throwing on invalid digest function name #20650

Merged
merged 3 commits into from
Jan 11, 2024

Commits on Dec 21, 2023

  1. DigestUtils: avoid throwing on invalid digest function name

    9% of samples in a profile of one of our builds were inside the `fillInStackTrace()` method. Collecting the valid names into a hashset avoids needing to construct errors every time an invalid digest function name is passed into this function.
    
    Tested with Bazel 6.4.0. Our codebase is not yet compatible with Bazel 7.
    
    I have not investigated why this function was receiving so many invalid names.
    
    Before:
    
    ![Screenshot 2023-12-15 at 2 39 01 pm](https://github.com/bazelbuild/bazel/assets/18002432/be4bd311-ca73-46ec-a06d-93bb0ca9c6ba)
    
    After:
    
    ![Screenshot 2023-12-15 at 2 43 10 pm](https://github.com/bazelbuild/bazel/assets/18002432/64b15739-538f-4752-aafd-6b2c94886595)
    
    My understanding is that this will not speed up builds directly, but it will allow BEP events to be processed more quickly.
    
    Closes bazelbuild#20574.
    
    PiperOrigin-RevId: 592094151
    Change-Id: Ie23241c9ec40e59ba2aac1fc83e4830340260f45
    christianscott authored and bazel-io committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    af7b876 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    0777d55 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    4836b2e View commit details
    Browse the repository at this point in the history