Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.1] Cherry-pick all presubmit.yml changes #20733

Merged
merged 11 commits into from
Jan 3, 2024

Conversation

Wyverald
Copy link
Member

@Wyverald Wyverald commented Jan 3, 2024

Hopefully this will fix our presubmits!

meteorcloudy and others added 10 commits January 3, 2024 13:57
PiperOrigin-RevId: 584328821
Change-Id: I995570340c3b1c28741fc41ba9658f3b148b44b9
Related #20288

PiperOrigin-RevId: 584584636
Change-Id: Iea064efe8d6caf9e60daf32e5408c325524685ca
*** Reason for rollback ***

Fix jdeps_test RBE failure

The culprit change added a new class that presumably pushed us over the xargs arg limit. Unfortunately, jdeps does not support @argfile, so this change updates the command buffer size to twice the default on RBE.

Fixes #20288

*** Original change description ***

Disable //src/test/shell/bazel:jdeps_test on RBE build to fix presubmit

Related #20288

PiperOrigin-RevId: 584820138
Change-Id: I6f5157d7e72c539a5fdc81841a35543df473aa4a
This should help reduce overall CI time by reducing the number of tests.

Closes #20346.

PiperOrigin-RevId: 586095997
Change-Id: I66f60e87a59ec8bcc730b88f821af6a18a914d8d
Work towards #18776.

Centos tests are still disabled because of python version issues: #18776 (comment)

Closes #20348.

PiperOrigin-RevId: 587674122
Change-Id: Id99b09d9dc184f015f02e4ebc921dcfa58adcc45
Fedora 39 is shipping GCC 13, modern C/C++ toolchain, so that adding it to CI platforms would help to detect breakages earlier, that related to modern C/C++ toolchains.

Closes #20405.

PiperOrigin-RevId: 587697147
Change-Id: Ib5adf1579991a85f1e2994fb86b1b9e7b25bad7f
Still seeing problems with finding python: https://buildkite.com/bazel/bazel-bazel/builds/25852#018c37b0-3cb4-4829-826b-eced53b34e5f

Part of #20437 and #18776.

Closes #20440.

PiperOrigin-RevId: 588180701
Change-Id: I8a0181f96df7612c72ce5e33336690f3a0efef15
To prevent further regressions on macOS.

Related: #20437
PiperOrigin-RevId: 588402302
Change-Id: I91fba9cad88c45626a51ee05b527bf7a3b66199b
Re-enable `minimal_jdk_test` with a higher tolerance.

Closes #20451.

PiperOrigin-RevId: 588756736
Change-Id: Ib26da4a31f942b1f0d7a3ed976389449f7995105
Those two are failing after upgrading to Xcode 14

PiperOrigin-RevId: 593039540
Change-Id: I12a1455cc09460c3bf0278a959de400f94988145
@Wyverald Wyverald requested a review from a team as a code owner January 3, 2024 18:59
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Android Issues for Android team labels Jan 3, 2024
@iancha1992 iancha1992 enabled auto-merge (squash) January 3, 2024 19:26
@iancha1992 iancha1992 removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 3, 2024
Due to #20660

RELNOTES: None
PiperOrigin-RevId: 593115090
Change-Id: Ifc2a282dbd6dd8a3abfec987398388e5844af91c
@Wyverald Wyverald removed the team-Android Issues for Android team label Jan 3, 2024
@iancha1992 iancha1992 merged commit 7a42ff3 into release-7.0.1 Jan 3, 2024
34 checks passed
@Wyverald Wyverald deleted the wyv-fix-test-701 branch January 3, 2024 20:34
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2024
Hopefully this will fix our presubmits!

---------

This is a copy of #20733 for the
7.1.0 branch.

Co-authored-by: Googler <pcloudy@google.com>
Co-authored-by: Googler <hvd@google.com>
Co-authored-by: John Cater <jcater@google.com>
Co-authored-by: David Ostrovsky <David.Ostrovsky@gmail.com>
Co-authored-by: Justin Horvitz <jhorvitz@google.com>
iancha1992 pushed a commit that referenced this pull request Jan 18, 2024
Baseline:  d798ebd

Release Notes:

+ Consider MODULE.bazel for workspace detection in bazel.sh (#20594)
+ Auto-create deploy jars for Bazel `java_test` targets if requested (#20602)
+ `java_binary` wrapper should forward `restricted_to` (#20611)
+ Mount user-specified bind mounts before Bazel's own magic. (#20609)
+ Fix bootstrapped Bazel binary (#20612)
+ Attempt to make main repo mapping inverse more efficient (#20625)
+ Cherry-pick all presubmit.yml changes (#20733)
+ Print interactive sandboxed shell command with `--sandbox_debug` (#20734)
+ Fix two issues with --incompatible_sandbox_hermetic_tmp that manifested themselves when the output base was under /tmp (#20718)
+ Let module extensions track calls to `Label()` (#20750)
+ Add support for bind mounts under `/tmp` with hermetic tmp (#20749)
+ Fixes for Bazel's own integration tests fail locally on Linux  (#20821)
+ Fix NPE in BzlmodRepoRuleFunction (#20828)
+ Avoid emitting canonical labels into generated repos (#20840)
+ Let .bzl files record their usages of repo mapping (#20848)
+ Force output checking for incremental run commands without the bytes. (#20881)
+ Retry binding to ipv6 localhost (#20903)
+ Fix linker feature detection being performed on wrong linker (#20901)
+ Fix singlejar resource mapping for external repositories (#20904)

Acknowledgements:

This release contains contributions from many people at Google, as well as bazel.build machine account, David Ostrovsky, Fabian Meumertzheim, hvd, Siddhartha Bagaria, Tianyu Geng, Xdng Yng, Xùdōng Yáng.
copybara-service bot pushed a commit that referenced this pull request Jan 18, 2024
Baseline:  d798ebd

Release Notes:

+ Consider MODULE.bazel for workspace detection in bazel.sh (#20594)
+ Auto-create deploy jars for Bazel `java_test` targets if requested (#20602)
+ `java_binary` wrapper should forward `restricted_to` (#20611)
+ Mount user-specified bind mounts before Bazel's own magic. (#20609)
+ Fix bootstrapped Bazel binary (#20612)
+ Attempt to make main repo mapping inverse more efficient (#20625)
+ Cherry-pick all presubmit.yml changes (#20733)
+ Print interactive sandboxed shell command with `--sandbox_debug` (#20734)
+ Fix two issues with --incompatible_sandbox_hermetic_tmp that manifested themselves when the output base was under /tmp (#20718)
+ Let module extensions track calls to `Label()` (#20750)
+ Add support for bind mounts under `/tmp` with hermetic tmp (#20749)
+ Fixes for Bazel's own integration tests fail locally on Linux  (#20821)
+ Fix NPE in BzlmodRepoRuleFunction (#20828)
+ Avoid emitting canonical labels into generated repos (#20840)
+ Let .bzl files record their usages of repo mapping (#20848)
+ Force output checking for incremental run commands without the bytes. (#20881)
+ Retry binding to ipv6 localhost (#20903)
+ Fix linker feature detection being performed on wrong linker (#20901)
+ Fix singlejar resource mapping for external repositories (#20904)

Acknowledgements:

This release contains contributions from many people at Google, as well as bazel.build machine account, David Ostrovsky, Fabian Meumertzheim, hvd, Siddhartha Bagaria, Tianyu Geng, Xdng Yng, Xùdōng Yáng.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants