Fix linker feature detection being performed on wrong linker #20833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead.
comius
approved these changes
Jan 12, 2024
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 15, 2024
Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead. Fixes bazelbuild#20834 Closes bazelbuild#20833. PiperOrigin-RevId: 598565598 Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jan 22, 2024
Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead. Fixes bazelbuild#20834 Closes bazelbuild#20833. PiperOrigin-RevId: 598565598 Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
…20990) Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead. Fixes #20834 Closes #20833. Commit 2bfe045 PiperOrigin-RevId: 598565598 Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6 --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel forces use of
lldandld.goldif found, but performed feature detection on the default linker instead.Fixes #20834