Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disregard WORKSPACE while verifying lockfile repo mapping entries in extension eval #20982

Closed
wants to merge 2 commits into from
Closed

Disregard WORKSPACE while verifying lockfile repo mapping entries in extension eval #20982

wants to merge 2 commits into from

Conversation

Wyverald
Copy link
Member

See code comment and linked issue for more information.

Fixes #20942.

@Wyverald
Disregard WORKSPACE while verifying lockfile repo mapping entries in …
92f4ab0 
…extension eval

See code comment and linked issue for more information.

Fixes #20942.
@Wyverald Wyverald requested a review from fmeum January 22, 2024 22:08
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 22, 2024
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 22, 2024
meteorcloudy
meteorcloudy approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice team work, thanks everyone!

@meteorcloudy
Copy link
Member

I wonder if we need another patch release for this issue? Or should we just go with 7.1.0?

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 23, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 23, 2024
@Wyverald @bazel-io
Disregard WORKSPACE while verifying lockfile repo mapping entries in …
44779b8 
…extension eval

See code comment and linked issue for more information.

Fixes bazelbuild#20942.

Closes bazelbuild#20982.

PiperOrigin-RevId: 600856392
Change-Id: I5b8a0ed3a38e37ab51ffb49b19a59f2e161b9a33
@bazel-io bazel-io mentioned this pull request Jan 23, 2024
Merged
iancha1992 pushed a commit that referenced this pull request Jan 23, 2024
@bazel-io @Wyverald
[7.0.2] Disregard WORKSPACE while verifying lockfile repo mapping ent…
457fc9b 
…ries in extension eval (#21003)

See code comment and linked issue for more information.

Fixes #20942.

Closes #20982.

Commit
21508b1

PiperOrigin-RevId: 600856392
Change-Id: I5b8a0ed3a38e37ab51ffb49b19a59f2e161b9a33

---------

Co-authored-by: Xdng Yng <wyverald@gmail.com>
@Wyverald Wyverald deleted the wyv-fix-20942 branch January 25, 2024 21:33
Wyverald added a commit that referenced this pull request Jan 25, 2024
@Wyverald
Disregard WORKSPACE while verifying lockfile repo mapping entries in …
623b137 
…extension eval

See code comment and linked issue for more information.

Fixes #20942.

Closes #20982.

PiperOrigin-RevId: 600856392
Change-Id: I5b8a0ed3a38e37ab51ffb49b19a59f2e161b9a33
@rrbutani rrbutani mentioned this pull request Feb 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel 7.0.1 reports cyclic dependency in rules_python
3 participants
@Wyverald @meteorcloudy @fmeum