Update default visionOS CPU to sim_arm64 #21150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
force-pushed
the
change-default-cpu-for-visionos
branch
from
4f15141
to
c8e069a
Compare
BalestraPatrick
changed the title
github-actions
bot
added
the
awaiting-review
brentleyjones
approved these changes
Jan 31, 2024
iancha1992
added
the
team-ExternalDeps
meteorcloudy
approved these changes
Feb 6, 2024
meteorcloudy
added
team-Rules-CPP
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 7, 2024
This is a follow-up to bazelbuild#20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes bazelbuild#21150. PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes #21150. Commit 6922aea PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930 Co-authored-by: Patrick Balestra <me@patrickbalestra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).