Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Use execution info instead of hard-coded mnemonics for Java path mapping #21461

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[7.1.0] Use execution info instead of hard-coded mnemonics for Java path mapping #21461

merged 1 commit into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. Use execution info instead of hard-coded mnemonics for Java path mapping 

    By removing Java rules from the hard-coded mnemonics allowlist for path mapping, users can rely on `--modify_execution_info` to selectively disable path mapping for them just like for Starlark actions.

This requires fixing two minor inconsistencies in how execution info is populated for Java actions:
* In `JavaCompilationHelper`, `buildKeepingLast` is used instead of `buildOrThrow` to prevent a crash when a target sets `supports-path-mapping` via `tags`.
* In `JavaHeaderCompileAction`, `--experimental_inmemory_jdeps_files` no longer causes all other execution info to be lost.

Fixes bazelbuild#21092

Closes bazelbuild#21093.

PiperOrigin-RevId: 609064092
Change-Id: I6803e34a6861f19d185542e707b00029ee018a0a
    @fmeum @iancha1992
    fmeum authored and iancha1992 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3cbb4aa View commit details
    Browse the repository at this point in the history