Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Fix fetch target (fixes #13847) #21527

Closed
wants to merge 7 commits into from
Closed

Commits on Feb 29, 2024

  1. Fix fetch target (fixes #13847)

    Context:
    - Traditional query relies on the initial loading phase of the build, this lacks the context of build configurations (flags, select() logic), leading to potentially inaccurate or over-inclusive dependency listings.
    
    - cquery executes after the analysis phase, where Bazel has resolved configurations and determined how options influence target definitions. This allows cquery to provide the dependencies truly needed for a build under the current settings.
    
    Considering these differences, I'm updating fetch target logic to rely on cquery instead. This ensures that all necessary repositories are fetched for an offline build while avoiding potential over-fetching
    
    PiperOrigin-RevId: 611455579
    Change-Id: I2a954476c06182fd9eb78ad86def7bd72f04074a
    
    # Conflicts:
    #	src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java
    SalmaSamy committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0074cdb View commit details
    Browse the repository at this point in the history
  2. explcitly traverse aspects in cquery

    This CL adds aspect nodes as explicit targets in cquery deps by making
    ConfiguredTargetQueryEnvironment generic over a new interface,
    CqueryNode, rather than ConfiguredTarget.
    
    CqueryNode is implemented by AspectKey as well as ConfiguredTarget so
    that both can be traversed in a deps query.
    
    PiperOrigin-RevId: 595509373
    Change-Id: I8a637cd3ed640907d2b1501bcd2b4a4507d183e7
    
    # Conflicts:
    #	src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java
    #	src/main/java/com/google/devtools/build/lib/query2/cquery/ProtoOutputFormatterCallback.java
    #	src/main/java/com/google/devtools/build/lib/rules/BUILD
    Googler authored and SalmaSamy committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7235628 View commit details
    Browse the repository at this point in the history
  3. Split out VisibleForSerialization from AutoCodec.

    This annotation is orthogonal to AutoCodec and creates a circular dependency in
    a later change.
    
    PiperOrigin-RevId: 579867965
    Change-Id: Iff7ab004d7635c32edb9de38231b2d4c93469c6f
    
    # Conflicts:
    #	src/main/java/com/google/devtools/build/lib/rules/BUILD
    #	src/main/java/com/google/devtools/build/lib/skyframe/TestCompletionValue.java
    aoeui authored and SalmaSamy committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5b623eb View commit details
    Browse the repository at this point in the history
  4. Fix import

    SalmaSamy committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7527f41 View commit details
    Browse the repository at this point in the history
  5. Fix import

    SalmaSamy committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1671752 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ec027e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    d33acee View commit details
    Browse the repository at this point in the history