Split ModuleThreadContext off from ModuleFileGlobals #21749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModuleFileGlobals used to serve as both the definition of Starlark methods available in MODULE.bazel files, *and* the state tracker for a module being built. This commit brings it more in line with other Starlark evaluation contexts where there's a simple object that just holds methods, and the actual state is stored in the StarlarkThread. ModuleThreadContext is that state object. This commit is a pure mechanical refactor with no behavioral changes. It paves the way for us to allow root module MODULE.bazel files to import other files. Work towards #17880.
github-actions
bot
added
team-Configurability
|
@zhengwei143 this PR includes a very small usage of |
Wyverald
removed
the
team-Configurability
|
@Wyverald Pretty sure this is the same issue as in #21702 (comment) |
|
https://github.com/bazelbuild/rules_java/releases/tag/7.5.0 has been released, we can just upgrade rules_java for Bazel. /cc @hvadehra |
|
meteorcloudy
approved these changes
Mar 21, 2024
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 25, 2024
ModuleFileGlobals used to serve as both the definition of Starlark methods available in MODULE.bazel files, *and* the state tracker for a module being built. This commit brings it more in line with other Starlark evaluation contexts where there's a simple object that just holds methods, and the actual state is stored in the StarlarkThread. ModuleThreadContext is that state object. This commit is a pure mechanical refactor with no behavioral changes. It paves the way for us to allow root module MODULE.bazel files to import other files. Work towards bazelbuild#17880. Closes bazelbuild#21749. PiperOrigin-RevId: 619261497 Change-Id: Ibff3a311e1788f7d8089ca194933cfb5fcc53ee0
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
ModuleFileGlobals used to serve as both the definition of Starlark methods available in MODULE.bazel files, *and* the state tracker for a module being built. This commit brings it more in line with other Starlark evaluation contexts where there's a simple object that just holds methods, and the actual state is stored in the StarlarkThread. ModuleThreadContext is that state object. This commit is a pure mechanical refactor with no behavioral changes. It paves the way for us to allow root module MODULE.bazel files to import other files. Work towards #17880. Closes #21749. PiperOrigin-RevId: 619261497 Change-Id: Ibff3a311e1788f7d8089ca194933cfb5fcc53ee0 Commit 9facaaa Co-authored-by: Xdng Yng <wyverald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleFileGlobals used to serve as both the definition of Starlark methods available in MODULE.bazel files, and the state tracker for a module being built. This commit brings it more in line with other Starlark evaluation contexts where there's a simple object that just holds methods, and the actual state is stored in the StarlarkThread. ModuleThreadContext is that state object.
This commit is a pure mechanical refactor with no behavioral changes. It paves the way for us to allow root module MODULE.bazel files to import other files.
Work towards #17880.