Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract yanked versions into a SkyFunction #21909

Closed
wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 5, 2024

Ensures that yanked version information is only downloaded once per module name, which reduces the number of files fetched during module resolution. On my machine, this reduces bazel mod deps runtime on Bazel itself by ~15%.

This also prepares for storing yanked version information in the lockfile.

Work towards #20369

@fmeum fmeum force-pushed the 20369-yanked-version-function branch from 1244207 to 62f2a4f Compare April 7, 2024 20:09
@fmeum fmeum marked this pull request as ready for review April 7, 2024 20:45
@fmeum fmeum requested review from a team, Wyverald and meteorcloudy as code owners April 7, 2024 20:45
@fmeum fmeum requested review from gregestren and removed request for a team April 7, 2024 20:45
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Apr 7, 2024
@satyanandak satyanandak added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 8, 2024
@satyanandak
Copy link

@fmeum Could you please take a look at the failing checks?

@fmeum fmeum force-pushed the 20369-yanked-version-function branch from 62f2a4f to 0fe5efe Compare April 8, 2024 07:21
@fmeum fmeum removed the request for review from gregestren April 8, 2024 07:22
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 8, 2024

@satyanandak Should be fixed now.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Apr 8, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 8, 2024

@bazel-io fork 7.2.0

Ensures that yanked version information is only downloaded once per module name, which reduces the number of files fetched during module resolution.

Work towards bazelbuild#20369
@fmeum fmeum force-pushed the 20369-yanked-version-function branch from 0fe5efe to 20b05e9 Compare April 16, 2024 10:33
@fmeum fmeum requested a review from Wyverald April 16, 2024 10:34
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 16, 2024

@bazel-io fork 7.2.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 17, 2024
Ensures that yanked version information is only downloaded once per module name, which reduces the number of files fetched during module resolution. On my machine, this reduces `bazel mod deps` runtime on Bazel itself by ~15%.

This also prepares for storing yanked version information in the lockfile.

Work towards bazelbuild#20369

Closes bazelbuild#21909.

PiperOrigin-RevId: 625617556
Change-Id: Ie4184def3b868470f93d584bbbbd7f704e1e9a82
@fmeum fmeum deleted the 20369-yanked-version-function branch April 17, 2024 10:42
github-merge-queue bot pushed a commit that referenced this pull request Apr 17, 2024
Ensures that yanked version information is only downloaded once per
module name, which reduces the number of files fetched during module
resolution. On my machine, this reduces `bazel mod deps` runtime on
Bazel itself by ~15%.

This also prepares for storing yanked version information in the
lockfile.

Work towards #20369

Closes #21909.

PiperOrigin-RevId: 625617556
Change-Id: Ie4184def3b868470f93d584bbbbd7f704e1e9a82

Commit
3052eff

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 26, 2024
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
Ensures that yanked version information is only downloaded once per module name, which reduces the number of files fetched during module resolution. On my machine, this reduces `bazel mod deps` runtime on Bazel itself by ~15%.

This also prepares for storing yanked version information in the lockfile.

Work towards bazelbuild#20369

Closes bazelbuild#21909.

PiperOrigin-RevId: 625617556
Change-Id: Ie4184def3b868470f93d584bbbbd7f704e1e9a82
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.2.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants