Extract Bazel registry creation into a SkyFunction #22040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of an ad-hoc cache maintained in `RegistryFactoryImpl` and prepares for making registries aware of hashes stored in the lockfile. Work towards bazelbuild#20369
fmeum
force-pushed
the
20369-registry-function
branch
from
0f07f1e
to
d1a9d52
Compare
fmeum
requested review from
gregestren
and removed request for
a team,
meteorcloudy and
gregestren
github-actions
bot
added
team-Configurability
Wyverald
approved these changes
Apr 18, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
sgowroji
removed
the
awaiting-PR-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
This gets rid of an ad-hoc cache maintained in `RegistryFactoryImpl` and prepares for making registries aware of hashes stored in the lockfile. Work towards #20369 Fixes #22052. Closes #22040. PiperOrigin-RevId: 626307340 Change-Id: I34b428553f7169c72ed7dddd2fe3ea5e6dca2a97 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This gets rid of an ad-hoc cache maintained in `RegistryFactoryImpl` and prepares for making registries aware of hashes stored in the lockfile. Work towards bazelbuild#20369 Closes bazelbuild#22040. PiperOrigin-RevId: 626307340 Change-Id: I34b428553f7169c72ed7dddd2fe3ea5e6dca2a97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of an ad-hoc cache maintained in
RegistryFactoryImpland prepares for making registries aware of hashes stored in the lockfile.Work towards #20369