[7.2.0] Replace most Bzlmod events with a Skyframe graph lookup #22265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retaining `Postable`s across the graph increases the memory usage of every dependent Skyframe node. `ModuleExtensionResolutionEvent` is replaced with a lookup of the "done" Skyframe nodes for extension evaluation in `BazelLockFileModule#afterCommand`. `RootModuleFileFixupEvent` is replaced with direct storage in `SingleExtensionEvalValue`. The validation of repos imported from an extension is moved into a separate `SkyFunction`. This simplifies `bazel mod tidy`, which no longer needs to swallow certain exceptions, and allows cache hits when only the (invalid) imports of an extension are modified even without the lockfile. The `BazelModuleResolutionEvent` is kept for now, but will become obsolete with the new lockfile format. Work towards #20369 Closes #22058. PiperOrigin-RevId: 628213907 Change-Id: I8ba19f5151a8183be5051c8d9280f93476db2272
github-actions
bot
added
awaiting-review
iancha1992
approved these changes
May 7, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retaining
Postables across the graph increases the memory usage of every dependent Skyframe node.ModuleExtensionResolutionEventis replaced with a lookup of the "done" Skyframe nodes for extension evaluation inBazelLockFileModule#afterCommand.RootModuleFileFixupEventis replaced with direct storage inSingleExtensionEvalValue. The validation of repos imported from an extension is moved into a separateSkyFunction. This simplifiesbazel mod tidy, which no longer needs to swallow certain exceptions, and allows cache hits when only the (invalid) imports of an extension are modified even without the lockfile.The
BazelModuleResolutionEventis kept for now, but will become obsolete with the new lockfile format.Work towards #20369
Closes #22058.
PiperOrigin-RevId: 628213907
Change-Id: I8ba19f5151a8183be5051c8d9280f93476db2272