Add basic C++ path mapping support #22445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
6526-cc-path-mapping
branch
8 times, most recently
from
1a21e7d
to
417c6d1
Compare
fmeum
force-pushed
the
6526-cc-path-mapping
branch
3 times, most recently
from
46e8993
to
5fed2d0
Compare
fmeum
force-pushed
the
6526-cc-path-mapping
branch
2 times, most recently
from
3e0ee8b
to
fd78ca8
Compare
github-actions
bot
added
team-Performance
fmeum
commented
May 26, 2024
|
|
||
| expect_log 'Hi there, lib1!' | ||
| expect_log 'Hi there, lib2!' | ||
| # Compilation actions for lib1, lib2 and main should result in cache hits due |
There was a problem hiding this comment.
@comius This test should serve as a representative example of what path mapping can do, but please let me know if there is any additional context I can provide to help you with the review.
fmeum
force-pushed
the
6526-cc-path-mapping
branch
from
fd78ca8
to
5be34a6
Compare
fmeum
force-pushed
the
6526-cc-path-mapping
branch
from
5be34a6
to
943ba4e
Compare
|
Sanity check: what's the story with debug symbols? |
At this point users need to opt in explicitly via |
comius
approved these changes
Jun 14, 2024
| tools, | ||
| outputs, | ||
| mandatoryOutputs, | ||
| null, |
There was a problem hiding this comment.
Readability: add /* localResources= */ . Only on arguments, where you can't figure out the parameter name. Same below.
src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeatures.java
Show resolved
Hide resolved
comius
removed
the
awaiting-review
|
I'll merge this manually, since other internal tests need fixups. |
Thanks, are you going to take care of the |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jun 24, 2024
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in bazelbuild#22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards bazelbuild#6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes bazelbuild#22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693
|
@bazel-io fork 7.3.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jun 24, 2024
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in bazelbuild#22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards bazelbuild#6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes bazelbuild#22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jun 24, 2024
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in bazelbuild#22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards bazelbuild#6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes bazelbuild#22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 5, 2024
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in bazelbuild#22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards bazelbuild#6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes bazelbuild#22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in #22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards #6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes #22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693 Closes #22875 Co-authored-by: Yun Peng <pcloudy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic support for path mapping for
CppCompileactions is added by wiring upPathMapperwith:ArtifactandNestedSet<PathFragment>)Spawn#getPathMapper()Also turns
external_include_pathsinto a structured variable, which was missed in #22463.The following features are known to be unsupported for now:
layering_check(requires rewriting paths to and in module maps)PathMapperinCppCompileActionTemplate)user_compile_flags)These limitations will be lifted in follow-up PRs.
Work towards #6526
RELNOTES: Experimental support for path mapping
CppCompileactions can be enabled via--modify_execution_info=CppCompile=+supports-path-mapping.