Use new String#indexOf overload for Starlark's stringFind
#23255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
Since Java 21, the internal `indexOf` method on String that accepts start and end position is available as public API.
iancha1992
added
team-Rules-Java
|
Unfortunately, for now we cannot use java21 features in any file under src/main/java/net/starlark because they are depended upon by several external projects which require building with jdk11 :/ |
github-actions
bot
removed
the
awaiting-review
github-actions
bot
added
the
awaiting-review
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Java 21, the internal
indexOfmethod on String that accepts start and end position is available as public API.