Propagate all experimental options to the exec configuration #23326
Conversation
fmeum
force-pushed
the
experimental-exec
branch
from
8363798
to
e3662cc
Compare
|
This is motivated by #23328, in which a number of tests based on |
fmeum
requested review from
a team,
lberki,
comius and
rickeylev
as code owners
fmeum
requested review from
aranguyen
and removed request for
a team,
comius and
rickeylev
github-actions
bot
added
team-Configurability
|
@lberki Could you review this as Bazel's "Chief Flag Officer"? :-) |
|
@lberki Friendly ping |
|
Uh, sorry. I'll defer to @gregestren here. This seems like a good idea on the surface. You also probably want to give |
|
I added a test for incompatible tests about a year ago, but back then I wasn't sure whether experimental flags should be treated in the same way. |
fmeum
force-pushed
the
experimental-exec
branch
from
70f4d24
to
d66ec86
Compare
src/test/java/com/google/devtools/build/lib/analysis/config/ExecutionTransitionFactoryTest.java
Outdated
Show resolved
Hide resolved
gregestren
removed
the
awaiting-review
gregestren
added
the
awaiting-PR-merge
|
Do we need re-review? |
Sorry, clicked the button accidentally while going over my pending PRs. |
| @@ -130,6 +130,28 @@ bazel_fragments["AndroidConfiguration.Options"] = fragment( | |||
| "//command_line_option:internal_persistent_busybox_tools", | |||
| "//command_line_option:internal_persistent_multiplex_busybox_tools", | |||
| "//command_line_option:incompatible_disable_native_android_rules", | |||
| "//command_line_option:android_databinding_use_androidx", | |||
There was a problem hiding this comment.
Hi @fmeum . We're trying to get this merged for Bazel 8.
Why were these flags added? Does this have something to do with the experimental_android_databinding_v2below?
github-actions
bot
removed
the
awaiting-PR-merge
Experimental flags that don't propagate to the exec configuration can create very surprising failure cases for both Bazel users and devs. Unless there is a valid reason to not propagate them, they should be.
This is now enforced by a test and existing flags have been cleaned up where possible. The test strategy is the same as for
incompatible_flags.