Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic optimizations, removed redundancies #235

Closed
wants to merge 1 commit into from
Closed

Basic optimizations, removed redundancies #235

wants to merge 1 commit into from

Conversation

mattBrzezinski
Copy link

Optimized CSS properties, removed redundancies, added closing tags to
HTML tags (could cause potential bugs in web browsers)

Optimized CSS properties, removed redundancies, added closing tags to
HTML tags (could cause potential bugs in web browsers)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mattBrzezinski
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@damienmg
Copy link
Contributor

damienmg commented Jun 9, 2015

This pull request is too long, does several things in one stuff (and contains typo). Such large / subject to discussion pull request should be submitted to gerrit (https://bazel-review.googlesource.com) so a complete review can be performed.

There are also guidelines to not change spacing or non-semantic change on line of code we don't change the semantic as it make it harder to follow the blaming annotation.

@damienmg damienmg closed this Jun 9, 2015
laszlocsomor added a commit to laszlocsomor/bazel that referenced this pull request Apr 13, 2018
The assertion in line bazelbuild#235 passes on Linux if the
limit is 9, on Darwin if it is 10.

Commenting out the code in BazelRulesModule.java
that automatically loads the sh_configure() rule
which instantiates @local_config_sh makes the test
pass with the old limit (8).

Change-Id: Ic2406a4da260b284e15852070d58472ca18340af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants