Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upb build with Clang 16 #23667

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ single_version_override(
patch_strip = 1,
patches = [
"//third_party/upb:00_remove_toolchain_transition.patch",
"//third_party/upb:01_remove_werror.patch",
],
)

Expand Down
19 changes: 19 additions & 0 deletions third_party/upb/01_remove_werror.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
diff --git a/bazel/upb_proto_library.bzl b/bazel/upb_proto_library.bzl
--- a/bazel/build_defs.bzl
+++ b/bazel/build_defs.bzl
@@ -34,13 +34,13 @@
_DEFAULT_CPPOPTS.extend([
"-Wextra",
# "-Wshorten-64-to-32", # not in GCC (and my Kokoro images doesn't have Clang)
- "-Werror",
+ # "-Werror",
"-Wno-long-long",
])
_DEFAULT_COPTS.extend([
"-std=c99",
"-pedantic",
- "-Werror=pedantic",
+ # "-Werror=pedantic",
"-Wall",
"-Wstrict-prototypes",
# GCC (at least) emits spurious warnings for this that cannot be fixed
1 change: 1 addition & 0 deletions third_party/upb/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ filegroup(

exports_files([
"00_remove_toolchain_transition.patch",
"01_remove_werror.patch",
])
Loading