[7.4.0] Allow unquoted canonical repository names with query
#23675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unquoted `query` words that start with `@@` are no longer broken on `+`, which allows the usage of unquoted canonical labels in expressions. In the very rare case of a shorthand form of a canonical label referring to a WORKSPACE repo (which contains no `+`), the `+` can be separated by a space to get the original behavior (e.g. `@@foo+bar` no longer means `@@foo//:foo + //bar:bar`, but `@@foo +bar` does. Closes bazelbuild#23600. PiperOrigin-RevId: 673763980 Change-Id: Ie5509647b4e04e2f72b908d609781c79cf7b06d4
github-actions
bot
added
awaiting-review
Wyverald
approved these changes
Sep 19, 2024
iancha1992
added
the
team-OSS
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 19, 2024
3300d15
51 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unquoted
querywords that start with@@are no longer broken on+, which allows the usage of unquoted canonical labels in expressions. In the very rare case of a shorthand form of a canonical label referring to a WORKSPACE repo (which contains no+), the+can be separated by a space to get the original behavior (e.g.@@foo+barno longer means@@foo//:foo + //bar:bar, but@@foo +bardoes.Closes #23600.
PiperOrigin-RevId: 673763980
Change-Id: Ie5509647b4e04e2f72b908d609781c79cf7b06d4
Fixes #23601