Fix _validation output group merging
#23676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While bazelbuild@cd72583 made it so that a rule and an aspect can both specify validation outputs, it accidentally didn't actually merge the `_validation` output groups. By adding the missing merge logic and having the `ValidateTarget` aspect depend on all other aspects, both a rule and an aspect returning a validation output is now fully supported with `--experimental_use_validation_aspect`. Closes bazelbuild#23589. PiperOrigin-RevId: 675294550 Change-Id: I581417bee223f0b6aedbc0ce71cae75cd6609ef7 (cherry picked from commit 750f0a1)
github-actions
bot
added
awaiting-review
lberki
approved these changes
Sep 19, 2024
|
I assume there was a merge conflict? |
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 19, 2024
ef26873
51 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While cd72583 made it so that a rule and an aspect can both specify validation outputs, it accidentally didn't actually merge the
_validationoutput groups.By adding the missing merge logic and having the
ValidateTargetaspect depend on all other aspects, both a rule and an aspect returning a validation output is now fully supported with--experimental_use_validation_aspect.Closes #23589.
PiperOrigin-RevId: 675294550
Change-Id: I581417bee223f0b6aedbc0ce71cae75cd6609ef7
(cherry picked from commit 750f0a1)
Fixes #23664