[7.4.0] Fix upb build with Clang 16 #23700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
fmeum
changed the title
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes bazelbuild#23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
meteorcloudy
approved these changes
Sep 23, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 23, 2024
4a32d7b
50 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Xcode 16,
upbfails its own-Werrorcheck due to using Clang extensions.Closes #23667.
PiperOrigin-RevId: 676957876
Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
Closes #23668