Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't HTML escape bazel mod JSON output #23785

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 27, 2024

Otherwise "<root>" ends up being escaped with Unicode escape sequences, which is unnecessarily complex.

Work towards #22691

@fmeum
Copy link
Collaborator Author

fmeum commented Sep 27, 2024

@bazel-io fork 7.4.0

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 27, 2024
@meteorcloudy
Copy link
Member

I have a change to address the python toolchain flaky error. Retried the failed job.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 27, 2024
Otherwise `"<root>"` ends up being escaped with Unicode escape sequences, which is unnecessarily complex.
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 30, 2024
@fmeum fmeum deleted the mod-no-escaping branch September 30, 2024 19:02
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 30, 2024
Otherwise `"<root>"` ends up being escaped with Unicode escape sequences, which is unnecessarily complex.

Work towards bazelbuild#22691

Closes bazelbuild#23785.

PiperOrigin-RevId: 680633877
Change-Id: Ic3c90c33bbf1209efa90be78b432e2132f0a1f05
github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2024
Otherwise `"<root>"` ends up being escaped with Unicode escape
sequences, which is unnecessarily complex.

Work towards #22691

Closes #23785.

PiperOrigin-RevId: 680633877
Change-Id: Ic3c90c33bbf1209efa90be78b432e2132f0a1f05

Commit
e959d78

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants