Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Cherry pick install_name and soname features #23862

Open
wants to merge 2 commits into
base: release-7.4.0
Choose a base branch
from
Open

[7.4.0] Cherry pick install_name and soname features #23862

wants to merge 2 commits into from

Conversation

keith
Copy link
Member

@keith keith commented Oct 3, 2024 •
edited
Loading

This cherry picks 62dc3b5 and 0b0d908 which allows setting install_name and soname on shared libraries. No defaults changed here.

Fixes #23842

fmeum and others added 2 commits October 3, 2024 16:16
@fmeum @keith
Flip --incompatible_macos_set_install_name
3d6de3c 
This requires adding the `set_install_name` feature to the Unix toolchain on macOS only. The legacy install name patcher is kept around for as long as the flag can be unflipped.

RELNOTES[INC]: With the default Unix toolchain on macOS, binaries now use `@rpath` to find their `.dylib` dependencies. This is required to fix issues where tools run during the build couldn't find their dynamic dependencies.

Closes bazelbuild#12370

Closes bazelbuild#23090.

PiperOrigin-RevId: 678780800
Change-Id: I13a1bb993c13fb2f9d7b358c2881a7ccdafe66cc
@keith
Add opt-in set_soname feature
5ca2c1c 
This allows correctly setting the `soname` for shared libraries on
Linux. This is useful for similar reasons to the macOS
`set_install_name` feature.

Fixes bazelbuild#18798

Closes bazelbuild#23839.

PiperOrigin-RevId: 681847016
Change-Id: I2d3584c9d91564b41c2501e6664e2956f9760e41
@keith keith requested a review from a team as a code owner October 3, 2024 23:18
@keith keith mentioned this pull request Oct 3, 2024
Open
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels Oct 3, 2024
@iancha1992 iancha1992 requested a review from comius October 3, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius Awaiting requested review from comius

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @fmeum