Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.1] Skip over runfiles middleman artifacts without a RunfilesSupplier #24086

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[7.4.1] Skip over runfiles middleman artifacts without a RunfilesSupplier #24086

merged 3 commits into from
Oct 25, 2024

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 24, 2024

Fixes #24061

@fmeum fmeum requested a review from a team as a code owner October 24, 2024 19:09
@fmeum fmeum requested review from tjgq and removed request for a team October 24, 2024 19:09
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 24, 2024
@fmeum fmeum requested a review from iancha1992 October 24, 2024 19:16
@iancha1992 iancha1992 added the team-Performance Issues for Performance teams label Oct 24, 2024
@iancha1992 iancha1992 enabled auto-merge (squash) October 24, 2024 20:42
@iancha1992 iancha1992 added this to the 7.4.1 release blockers milestone Oct 24, 2024
@iancha1992 iancha1992 changed the title Skip over runfiles middleman artifacts without a RunfilesSupplier [7.4.1] Skip over runfiles middleman artifacts without a RunfilesSupplier Oct 24, 2024
tjgq
tjgq approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tjgq tjgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 25, 2024
@iancha1992 iancha1992 merged commit b86ef42 into bazelbuild:release-7.4.1 Oct 25, 2024
50 checks passed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 25, 2024
@fmeum fmeum deleted the 24061-bazel-7 branch October 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

@iancha1992 iancha1992 Awaiting requested review from iancha1992

Assignees
No one assigned
Labels
team-Performance Issues for Performance teams
Projects
None yet
Milestone
7.4.1 release blockers
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @tjgq @iancha1992