Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty package in AutoBazelRepositoryProcessor #24161

Closed
wants to merge 1 commit into from

Conversation

fzakaria
Copy link
Contributor

Add support for when the AutoBazelRepository annotation is placed on a file in a root package (ie. one where there is no package)

fixes #24150

Add support for when the AutoBazelRepository annotation is placed
on a file in a root package (ie. one where there is no package)

fixes bazelbuild#24150
@github-actions github-actions bot added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 31, 2024
Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmeum
Copy link
Collaborator

fmeum commented Oct 31, 2024

@bazel-io fork 8.0.0

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 31, 2024
@copybara-service copybara-service bot closed this in 1560047 Nov 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 4, 2024
fmeum added a commit to fmeum/rules_java that referenced this pull request Nov 4, 2024
@fzakaria fzakaria deleted the issue-24150 branch November 4, 2024 21:52
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Nov 4, 2024
Add support for when the AutoBazelRepository annotation is placed on a file in a root package (ie. one where there is no package)

fixes bazelbuild#24150

Closes bazelbuild#24161.

PiperOrigin-RevId: 692888334
Change-Id: Idd85e79250f64cf50ca709cf6ad8d025a0db032c
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2024
Add support for when the AutoBazelRepository annotation is placed on a
file in a root package (ie. one where there is no package)

fixes #24150

Closes #24161.

PiperOrigin-RevId: 692888334
Change-Id: Idd85e79250f64cf50ca709cf6ad8d025a0db032c

Commit
1560047

Co-authored-by: Farid Zakaria <farid.m.zakaria@gmail.com>
fmeum added a commit to fmeum/rules_java that referenced this pull request Nov 5, 2024
fmeum added a commit to fmeum/rules_java that referenced this pull request Nov 5, 2024
fmeum added a commit to fmeum/rules_java that referenced this pull request Nov 5, 2024
fmeum added a commit to fmeum/rules_java that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoBazelRepository in empty package fails
3 participants