Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Extract methods to acquire and release a filesystem lock. #24223

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Nov 6, 2024

They are currently only used to acquire a lock on the output base, but a future change will use them to lock the install base as well.

Human-readable output is also amended to refer to the "output base lock" instead of the "client lock", as the latter term becomes ambiguous once multiple locks exist.

Progress on #2109.

PiperOrigin-RevId: 693354279
Change-Id: I2b39e6f5ddb83bbc2be15a31d7de9655358776c5

They are currently only used to acquire a lock on the output base, but a future change will use them to lock the install base as well.

Human-readable output is also amended to refer to the "output base lock" instead of the "client lock", as the latter term becomes ambiguous once multiple locks exist.

Progress on bazelbuild#2109.

PiperOrigin-RevId: 693354279
Change-Id: I2b39e6f5ddb83bbc2be15a31d7de9655358776c5
@tjgq tjgq requested a review from a team as a code owner November 6, 2024 12:13
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 6, 2024
@iancha1992 iancha1992 added this to the 8.0.0 release blockers milestone Nov 6, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into bazelbuild:release-8.0.0 with commit a01a1fa Nov 6, 2024
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants