[8.0.0] Match --worker_extra_flag against the worker key mnemonic, not the action mnemonic, as is the case for other worker flags taking a mnemonic. #24251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion mnemonic, as is the case for other worker flags taking a mnemonic. Fixes bazelbuild#24237. RELNOTES[INC]: The mnemonic passed to --worker_extra_flag is now matched against the worker key mnemonic when one is available, instead of the action mnemonic. This makes it consistent with other worker flags taking a mnemonic. PiperOrigin-RevId: 694436563 Change-Id: I7c6e6ede5e3ef2f53aeb847bbfe173042c528d68
bazel-io
added
team-Local-Exec
tjgq
approved these changes
Nov 8, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24237.
RELNOTES[INC]: The mnemonic passed to --worker_extra_flag is now matched against the worker key mnemonic when one is available, instead of the action mnemonic. This makes it consistent with other worker flags taking a mnemonic.
PiperOrigin-RevId: 694436563
Change-Id: I7c6e6ede5e3ef2f53aeb847bbfe173042c528d68
Commit 8357fba