[8.0.0] Preserve analysis cache through --run_under command changes
#24352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the way, also trim `CoverageOptions` as part of the test trimming configuration, matching the logic in `TestConfiguration#SHOULD_INVALIDATE_FOR_OPTION_DIFF`. Also refactor `RunUnder` into a sealed interface implemented by two records. Work towards bazelbuild#3325 Fixes bazelbuild#10782 RELNOTES: Changing any part of `--run_under` that isn't the label (such as the shell command) no longer invalidates the analysis cache. Closes bazelbuild#24303. PiperOrigin-RevId: 696887935 Change-Id: I79a2c153862c33b2ff25eefa4069bc11e99ea9d6
iancha1992
added
team-Configurability
github-actions
bot
removed
the
awaiting-review
|
The original change is being rolled back: see #24303 (comment) for the reason. We should also remove this commit from 8.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way, also trim
CoverageOptionsas part of the test trimming configuration, matching the logic inTestConfiguration#SHOULD_INVALIDATE_FOR_OPTION_DIFF. Also refactorRunUnderinto a sealed interface implemented by two records.Work towards #3325
Fixes #10782
RELNOTES: Changing any part of
--run_underthat isn't the label (such as the shell command) no longer invalidates the analysis cache.Closes #24303.
PiperOrigin-RevId: 696887935
Change-Id: I79a2c153862c33b2ff25eefa4069bc11e99ea9d6
Commit 4515bb6