Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get --repo_env=NAME value from client environment (not server). #24433

Closed

Conversation

Silic0nS0ldier
Copy link
Contributor

Fixes issue where server process would "cache" environment variables. Broken since 3ebf658 (v5).

Fixes issue where server process would "cache" environment variables. Broken since 3ebf658 (v5).
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 21, 2024
@fmeum
Copy link
Collaborator

fmeum commented Nov 21, 2024

@bazel-io fork 8.0.0

@fmeum
Copy link
Collaborator

fmeum commented Nov 21, 2024

@meteorcloudy

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 21, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 21, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Nov 21, 2024
Fixes issue where server process would "cache" environment variables. Broken since 3ebf658 (v5).

Closes bazelbuild#24433.

PiperOrigin-RevId: 698847238
Change-Id: I51d4ec811ee9d78717ff816d9988b4ad0f533265
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2024
…er). (#24441)

Fixes issue where server process would "cache" environment variables.
Broken since 3ebf658 (v5).

Closes #24433.

PiperOrigin-RevId: 698847238
Change-Id: I51d4ec811ee9d78717ff816d9988b4ad0f533265

Commit
a590cfc

Co-authored-by: Jordan Mele <jordan.mele@outlook.com.au>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 8.0.0 RC3. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.0.0rc3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants