Do not forward legacy cmd.exe variables to the server
#24451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
24448-client-env
branch
2 times, most recently
from
3262743 to
8332050
Compare
This fixes startup failures such as: ``` ERROR: While parsing option --client_env==C:=C:\Users\wyv: Variable definitions must be in the form of a 'name=value' assignment ```
fmeum
force-pushed
the
24448-client-env
branch
from
03577db to
b757417
Compare
fmeum
changed the title
cmd.exe variables to the server
github-actions
bot
added
team-Rules-CPP
|
GitHub has a partial outage. |
meteorcloudy
approved these changes
Nov 22, 2024
|
Thanks! I'll import this one now |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 22, 2024
This fixes startup failures such as: ``` ERROR: While parsing option --client_env==C:=C:\Users\wyv: Variable definitions must be in the form of a 'name=value' assignment ``` Fixes bazelbuild#24448 Closes bazelbuild#24451. PiperOrigin-RevId: 699115724 Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This fixes startup failures such as: ``` ERROR: While parsing option --client_env==C:=C:\Users\wyv: Variable definitions must be in the form of a 'name=value' assignment ``` Fixes #24448 Closes #24451. PiperOrigin-RevId: 699115724 Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b Commit 59eb519 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
keertk
added a commit
that referenced
this pull request
Nov 26, 2024
…rver (#24500) This fixes startup failures such as: ``` ERROR: While parsing option --client_env==C:=C:\Users\wyv: Variable definitions must be in the form of a 'name=value' assignment ``` Fixes #24448 Closes #24451. PiperOrigin-RevId: 699115724 Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes startup failures such as:
Fixes #24448