Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1.0] Add --incompatible_enforce_starlark_utf8 #25152

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 31, 2025

If enabled (or set to error), fail if Starlark files are not UTF-8 encoded. If set to warning (the default), emits a warning instead.

Bazel already assumes that Starlark files are UTF-8 encoded for e.g. filenames in actions executed remotely. This flag doesn't affect this, it only makes encoding failures more visible.

Work towards #374

Closes #24944.

PiperOrigin-RevId: 721513249
Change-Id: I1d3363168c6cd5d37abf96e0401e34866b6679d7

(cherry picked from commit e7934ce)

Fixes #25148

If enabled (or set to `error`), fail if Starlark files are not UTF-8 encoded. If set to `warning` (the default), emits a warning instead.

Bazel already assumes that Starlark files are UTF-8 encoded for e.g. filenames in actions executed remotely. This flag doesn't affect this, it only makes encoding failures more visible.

Work towards bazelbuild#374

Closes bazelbuild#24944.

PiperOrigin-RevId: 721513249
Change-Id: I1d3363168c6cd5d37abf96e0401e34866b6679d7

(cherry picked from commit e7934ce)
@fmeum fmeum requested a review from a team as a code owner January 31, 2025 08:29
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 31, 2025
@fmeum fmeum requested a review from tetromino January 31, 2025 08:40
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 31, 2025

@iancha1992

@iancha1992 iancha1992 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into bazelbuild:release-8.1.0 with commit 549e13e Jan 31, 2025
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants