Have RunfilesTree#getMapping return a SortedMap
#25625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It already always returns a `SortedMap` in production code, but signaling this on the type level makes it safer to consume the map in contexts where sorting is required, e.g. when computing Merkle trees. Also drop an impossible switch case.
fmeum
requested review from
katre and
lberki
and removed request for
a team and
katre
github-actions
bot
added
team-Performance
|
@lberki Friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It already always returns a
SortedMapin production code, but signaling this on the type level makes it safer to consume the map in contexts where sorting is required, e.g. when computing Merkle trees.Also drop an impossible switch case in adjacent code that is flagged by an IDE lint.