Support DebugFission with cc_configure
#6606
Conversation
GregBowyer
force-pushed
the
cc_configure_debug_fission
branch
from
d0765db to
3f18ad7
Compare
|
This looks purty |
|
fyi @mhlopko is OOO for the next two weeks. |
|
@mhlopko any chance for a review? |
|
Hi Greg, I'm sorry you had to wait this long. I'm back from the vacation and I'll take a look next week. I want to double check how gcc/clang/clang on mac behave so we detect fission properly, and I want to rediscover what 'is_using_fission' crosstool variable is for and investigate opportunities for cleanup. Stay tuned :) |
|
Should I rebase this? |
|
What's the status of this? @scentini? |
| cc, | ||
| "-gsplit-dwarf", | ||
| "-g", | ||
| "-c", |
There was a problem hiding this comment.
You probably need to add -o /dev/null to avoid a non-sensical output file in the tools tree.
|
@GregBowyer This is very old and would need work to update. Is it still valid? |
|
Doubtful lets close it out and redo it given all the changes to cc rules |
This is a basic PR to hopefully try to support DebugFission with toolchains / CROSSTOOLS that are autogenerated from the
cc_configurerules.I do not know if there is additional work to be done here, I am guessing it might be good to not only attempt the flag but also ensure linkage happens.