Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing documentation for some Java rules #7061

Closed
wants to merge 1 commit into from

Conversation

jin
Copy link
Member

@jin jin commented Jan 8, 2019

This adds a missing filegroup target to the sources of the Build Encyclopedia generator.

Fixes #6619

Change-Id: Ib4722c890026e5f599aa5c80d78b7fc6d9624804
@jin jin added the team-Rules-Java Issues for Java rules label Jan 8, 2019
@jin jin requested review from cushon and iirina January 8, 2019 22:29
Copy link
Contributor

@iirina iirina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pfff so that's what was missing! Thank you!

@bazel-io bazel-io closed this in 1422688 Jan 9, 2019
@Profpatsch
Copy link
Contributor

Maybe you can add a linter that sanity-checks whether all such classes also appear in that BUILD file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants