Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for incompatible change process. #7098

Merged
merged 8 commits into from
Jan 17, 2019

Conversation

dslomov
Copy link
Contributor

@dslomov dslomov commented Jan 11, 2019

Change-Id: I6129e587ffde66fd7d4ba26c147ae7c12409f3d2

Change-Id: I6129e587ffde66fd7d4ba26c147ae7c12409f3d2
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this

site/docs/backward-compatibility.md Outdated Show resolved Hide resolved
site/docs/backward-compatibility.md Show resolved Hide resolved
site/docs/backward-compatibility.md Outdated Show resolved Hide resolved
site/docs/backward-compatibility.md Outdated Show resolved Hide resolved
site/docs/backward-compatibility.md Outdated Show resolved Hide resolved
site/docs/skylark/backward-compatibility.md Outdated Show resolved Hide resolved
@iirina iirina added the team-Bazel General Bazel product/strategy issues label Jan 14, 2019
jin and others added 3 commits January 15, 2019 09:26
Co-Authored-By: dslomov <dslomov@google.com>
Co-Authored-By: dslomov <dslomov@google.com>
@dslomov
Copy link
Contributor Author

dslomov commented Jan 15, 2019

Ready for another look

Change-Id: I58b3296f3a7e079984282d57f05d828a682c3c1f
@dslomov
Copy link
Contributor Author

dslomov commented Jan 16, 2019

PTAL

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

site/docs/skylark/backward-compatibility.md Outdated Show resolved Hide resolved
Change-Id: Ib1c98ff4bbb3a999b7ea28ae67445c25fec0d1a0
@dslomov
Copy link
Contributor Author

dslomov commented Jan 16, 2019

@jin and @spomorski looks ok to you too?

Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dslomov dslomov merged commit 51e22db into bazelbuild:master Jan 17, 2019
bazel-io pushed a commit that referenced this pull request Jan 18, 2019
Change-Id: I6129e587ffde66fd7d4ba26c147ae7c12409f3d2

Closes #7098.

Change-Id: Ib1c98ff4bbb3a999b7ea28ae67445c25fec0d1a0
PiperOrigin-RevId: 229877377
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this pull request Jan 31, 2019
Change-Id: I6129e587ffde66fd7d4ba26c147ae7c12409f3d2

Closes bazelbuild#7098.

Change-Id: Ib1c98ff4bbb3a999b7ea28ae67445c25fec0d1a0
PiperOrigin-RevId: 229877377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Bazel General Bazel product/strategy issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants