Add incompatible flags for using the remote Java tools for the default java_toolchain and host_java_toolchain. #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
changed the title
meisterT
reviewed
Jan 18, 2019
src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
Outdated
Show resolved
Hide resolved
meisterT
approved these changes
Jan 18, 2019
src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java
Outdated
Show resolved
Hide resolved
|
Thanks for the code review! |
|
|
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
…t java_toolchain and host_java_toolchain. This PR introduces the flags: * `--incompatible_use_remote_host_java_toolchain` * `--incompatible_use_remote_java_toolchain` Progress on bazelbuild#6316 bazelbuild#7196 bazelbuild#7197 Closes bazelbuild#7156. PiperOrigin-RevId: 230209934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the flags:
--incompatible_use_remote_host_java_toolchain--incompatible_use_remote_java_toolchainProgress on #6316.