remote: fix unexpected IO error (not a directory) #7174
Closed
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
approved these changes
Jan 18, 2019
|
Does this change also fix #7160? |
laszlocsomor
approved these changes
Jan 18, 2019
| /** | ||
| * Returns the {@link Path} for an {@link ActionInput}. | ||
| */ | ||
| public static Path toPath(ActionInput input, Path execRoot) { |
There was a problem hiding this comment.
nit: could you call it "toInputPath" or something more concrete than "toPath"? Otherwise the sloppy hurried coder (not that I speak of my own experience, *ahem*) might believe this function does nothing but a trivial conversion (e.g. calling Artifact.toPath).
aehlig
pushed a commit
that referenced
this pull request
Jan 18, 2019
Closes #7174. PiperOrigin-RevId: 229914032
buchgr
added a commit
to buchgr/bazel
that referenced
this pull request
Jan 18, 2019
Like bazelbuild#7174, but only affecting remote execution. Also, incorporate feedback from bazelbuild#7174 and rename toPath to toInputPath.
This was referenced Jan 18, 2019
aehlig
pushed a commit
that referenced
this pull request
Jan 23, 2019
Closes #7174. PiperOrigin-RevId: 229914032
aehlig
pushed a commit
that referenced
this pull request
Jan 23, 2019
Closes #7174. PiperOrigin-RevId: 229914032
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
Closes bazelbuild#7174. PiperOrigin-RevId: 229914032
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
Like bazelbuild#7174, but only affecting remote execution. Also, incorporate feedback from bazelbuild#7174 and rename toPath to toInputPath. Closes bazelbuild#7181. PiperOrigin-RevId: 230211153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.