Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitelist file for starlark transitions #7535

Closed
wants to merge 3 commits into from
Closed

Add whitelist file for starlark transitions #7535

wants to merge 3 commits into from

Conversation

juliexxia
Copy link
Contributor

Whitelist all the things!

programmablereya
programmablereya approved these changes Feb 27, 2019
View reviewed changes
Copy link

@programmablereya programmablereya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :D Nice way to take care of this problem with little trouble!

@dslomov
Copy link
Contributor

dslomov commented Feb 28, 2019

What is the intent of this? Does this whitelist transitions in external repositories?

@bazel-io bazel-io closed this in 8536172 Feb 28, 2019
@juliexxia
Copy link
Contributor Author

Reopening to whitelist external dependencies

@juliexxia juliexxia reopened this Feb 28, 2019
@juliexxia juliexxia mentioned this pull request Mar 7, 2019
Closed
bazel-io pushed a commit that referenced this pull request Mar 11, 2019
@juliexxia @copybara-github
Add a test that verifies that //... package group includes external d…
868ab01 
…ependencies.

#7056 and #7535

PiperOrigin-RevId: 237874514
@deeglaze
Copy link
Contributor

deeglaze commented Apr 5, 2019

Is the requirement for the whitelist label equaling the //tools/etc path going to work when the reference is @bazel_tools//tools/etc ?

@jin jin added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Jun 10, 2019
@jin
Copy link
Member

jin commented Jun 10, 2019

What's the current status of this PR?

@gregestren gregestren mentioned this pull request Jun 20, 2019
Closed
@juliexxia
Copy link
Contributor Author

@jin I believe this is now obsolete because of commit 8536172. Closing. Thanks for the ping!

@juliexxia juliexxia closed this Jul 1, 2019
@philwo philwo deleted the juliexxia-patch-1 branch January 26, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmablereya programmablereya programmablereya approved these changes

Assignees
No one assigned
Labels
cla: yes team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliexxia @dslomov @deeglaze @jin @programmablereya @googlebot