Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: add --incompatible_windows_native_test_wrapper #7644

Closed
wants to merge 1 commit into from
Closed

Windows: add --incompatible_windows_native_test_wrapper #7644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.google.devtools.common.options.OptionDefinition;
import com.google.devtools.common.options.OptionDocumentationCategory;
import com.google.devtools.common.options.OptionEffectTag;
import com.google.devtools.common.options.OptionMetadataTag;
import com.google.devtools.common.options.OptionsParser;
import com.google.devtools.common.options.OptionsParsingException;
import com.google.devtools.common.options.TriState;
Expand Down Expand Up @@ -211,7 +212,7 @@ public static class TestOptions extends FragmentOptions {
public Label coverageReportGenerator;

@Option(
name = "experimental_windows_native_test_wrapper",
name = "incompatible_windows_native_test_wrapper",
// Design:
// https://github.com/laszlocsomor/proposals/blob/win-test-runner/designs/2018-07-18-windows-native-test-runner.md
documentationCategory = OptionDocumentationCategory.TESTING,
Expand All @@ -221,6 +222,10 @@ public static class TestOptions extends FragmentOptions {
OptionEffectTag.LOADING_AND_ANALYSIS,
OptionEffectTag.TEST_RUNNER,
},
metadataTags = {
OptionMetadataTag.INCOMPATIBLE_CHANGE,
OptionMetadataTag.TRIGGERED_BY_ALL_INCOMPATIBLE_CHANGES,
},
defaultValue = "false",
help =
"On Windows: if true, uses the C++ test wrapper to run tests, otherwise uses "
Expand Down
4 changes: 2 additions & 2 deletions src/test/py/bazel/test_wrapper_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ def _AssertXmlGeneratedByTestIsRetained(self, flag, split_xml=False):

def testTestExecutionWithTestSetupSh(self):
self._CreateMockWorkspace()
flag = '--noexperimental_windows_native_test_wrapper'
flag = '--noincompatible_windows_native_test_wrapper'
self._AssertPassingTest(flag)
self._AssertFailingTest(flag)
self._AssertPrintingTest(flag)
Expand Down Expand Up @@ -596,7 +596,7 @@ def testTestExecutionWithTestSetupSh(self):

def testTestExecutionWithTestWrapperExe(self):
self._CreateMockWorkspace()
flag = '--experimental_windows_native_test_wrapper'
flag = '--incompatible_windows_native_test_wrapper'
self._AssertPassingTest(flag)
self._AssertFailingTest(flag)
self._AssertPrintingTest(flag)
Expand Down