Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the default value of the incompatible_disable_genrule_cc_toolchain_dependency #7878

Closed
wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Mar 28, 2019

Flip --incompatible_disable_genrule_cc_toolchain_dependency flag.

Fixes #6867.

RELNOTES: The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details).

incompatible_disable_genrule_cc_toolchain_dependency flag.

RELNOTES: The --incompatible_disable_genrule_cc_toolchain_dependency flag now defaults to  true.
@katre katre requested a review from lberki as a code owner March 28, 2019 17:27
@katre katre requested a review from hlopko March 28, 2019 17:28
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bazel-io bazel-io closed this in 5e3dcde Mar 29, 2019
@katre katre deleted the i6867-flip-genrule-cc-flag branch April 3, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants