Pack all multi-arch libraries from aar_import deps when using --fat_apk_cpu #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If8dcc406592dc833f5732a81f04cf285693f2fb3
jin
changed the title
Change-Id: I4f9bee27d450530a5030b8e71961442141f0d6e5
Change-Id: I12f71bf47961b5d45d72123338f66c60ff919982
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
…pk_cpu Currently if `--fat_apk_cpu` is specified with more than one architecture and there are `aar_import` dependencies containing shared libraries for multiple architectures, android_binary will only pack one of the shared libraries. This is because it's unaware of the split transition during artifact discovery. RELNOTES: Fixed an issue with Android builds where `--fat_apk_cpu` doesn't pack all selected shared libraries from `aar_import` targets into the APK. See [bazelbuild#8283](bazelbuild#8283). Fixes bazelbuild#8283 Closes bazelbuild#8510. Change-Id: I5432aff47310c4ca8881d41be226829c98254ea5 PiperOrigin-RevId: 250776117
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
…pk_cpu Currently if `--fat_apk_cpu` is specified with more than one architecture and there are `aar_import` dependencies containing shared libraries for multiple architectures, android_binary will only pack one of the shared libraries. This is because it's unaware of the split transition during artifact discovery. RELNOTES: Fixed an issue with Android builds where `--fat_apk_cpu` doesn't pack all selected shared libraries from `aar_import` targets into the APK. See [bazelbuild#8283](bazelbuild#8283). Fixes bazelbuild#8283 Closes bazelbuild#8510. Change-Id: I5432aff47310c4ca8881d41be226829c98254ea5 PiperOrigin-RevId: 250776117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
--fat_apk_cpuis specified with more than one architecture and there areaar_importdependencies containing shared libraries for multiple architectures, android_binary will only pack one of the shared libraries. This is because it's unaware of the split transition during artifact discovery.RELNOTES: Fixed an issue with Android builds where
--fat_apk_cpudoesn't pack all selected shared libraries fromaar_importtargets into the APK.Fixes #8283