rule_test: apply "tags" to all rules in the macro #8784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES: rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, bazelbuild#8723
Fixes bazelbuild#8723
Change-Id: I25ac338e4978084085b8c49d6d0a1c47d8dc4fd1
Change-Id: Iee65afe1b7b8d3f2e09057804249396193ed241b
This was referenced Jul 3, 2019
c-parsons
approved these changes
Jul 3, 2019
|
Oh no, I noticed this breaks down with test-specific attributes (e.g. Let me fix this and I'll ping this thread. |
Change-Id: Ie53b8787ab8679ff4896820ef552c2696eac1d09
|
Done. |
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
RELNOTES: rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, bazelbuild#8723
Fixes bazelbuild#8723
Change-Id: I25ac338e4978084085b8c49d6d0a1c47d8dc4fd1
Closes bazelbuild#8784.
Change-Id: Ie53b8787ab8679ff4896820ef552c2696eac1d09
PiperOrigin-RevId: 256509917
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
RELNOTES: rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, bazelbuild#8723
Fixes bazelbuild#8723
Change-Id: I25ac338e4978084085b8c49d6d0a1c47d8dc4fd1
Closes bazelbuild#8784.
Change-Id: Ie53b8787ab8679ff4896820ef552c2696eac1d09
PiperOrigin-RevId: 256509917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, #8723
Fixes #8723
Change-Id: I25ac338e4978084085b8c49d6d0a1c47d8dc4fd1