Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --incompatible_disallow_legacy_javainfo. #9156

Closed
wants to merge 5 commits into from
Closed

Flip --incompatible_disallow_legacy_javainfo. #9156

wants to merge 5 commits into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Aug 13, 2019 •
edited
Loading

Fixes #5821.

@iirina
Copy link
Contributor Author

iirina commented Aug 13, 2019

Flip after bazel-contrib/rules_jvm_external#223 is merged.

@iirina iirina requested a review from lberki August 13, 2019 08:31
lberki
lberki approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/happydance

@bazel-io bazel-io closed this in 81216e3 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@c-parsons c-parsons Awaiting requested review from c-parsons

@dslomov dslomov Awaiting requested review from dslomov

@laurentlb laurentlb Awaiting requested review from laurentlb

@vladmos vladmos Awaiting requested review from vladmos

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incompatible_disallow_legacy_javainfo: Remove legacy (deprecated) JavaInfo constructors
3 participants
@iirina @lberki @googlebot