Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'remove_legacy_create_init_py' flag #9271

Closed
wants to merge 6 commits into from
Closed

Add 'remove_legacy_create_init_py' flag #9271

wants to merge 6 commits into from

Commits on Aug 28, 2019

  1. Added a migration flag to set 'legacy_create_init' to false by default

    @asafflesch
    asafflesch committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    de089bb View commit details
    Browse the repository at this point in the history

  2. Added tests around the 'incompatible_remove_legacy_create_init' flag

    @asafflesch
    asafflesch committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    9ca283e View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Changed legacy_create_init from a BOOLEAN value to a TRISTATE value, … 

    …so the new incompatible_remove_legacy flag can control the unset default
    @asafflesch
    asafflesch committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    26b19af View commit details
    Browse the repository at this point in the history

  2. legacy_create_init's value, if explicitly set, is left in place

    @asafflesch
    asafflesch committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    52e9e88 View commit details
    Browse the repository at this point in the history

  3. Added tests to reflect that a direct setting of the legacy_create_ini… 

    …t attribute overrides the migration flag
    @asafflesch
    asafflesch committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    a65d88c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/bazelbuild/bazel into asa… 

    …f.add_legacy_init_py_flag
    @asafflesch
    asafflesch committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5c6af74 View commit details
    Browse the repository at this point in the history