fix build for Power #9346
fix build for Power #9346
Conversation
The zip -d flag will error if it doesn't find that extension. This is a fix for Power, but doesn't fix the default case. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
clnperez
force-pushed
the
ppc-zip-fix
branch
from
6135717 to
99775df
Compare
irengrig
added
the
team-Configurability
|
Has the default case never worked, then? |
@gregestren probably not. that code was introduced 4 months ago. since it's new-ish maybe hasn't been hit until now. |
| @@ -10,6 +10,12 @@ filegroup( | |||
| visibility = ["//src:__pkg__"], | |||
| ) | |||
|
|
|||
| config_setting( | |||
| name = "linux_ppc", | |||
There was a problem hiding this comment.
Shouldppc should imply Linux? I see there's already precedent for aarch64 so I guess it's not a huge deal.
There was a problem hiding this comment.
yah that's just a convention i've seen and stuck with. but you're right, for now bazel doesn't run on aix or i :)
|
did this get merged? i'm not sure why it's closed |
|
yes: 5cff4f1 We don't merge pull requests directly in this repo. They get imported to the internal review system and exported out as commits. |
|
It looks like only one of those files got merged @jin https://github.com/bazelbuild/bazel/blob/master/third_party/BUILD#L531 |
|
Ah, I see it. third_party changes need to be broken out from PRs into a separate PR. Please open a new PR containing the change for third_party and I (or @gregestren) can import it manually./ |
The zip -d flag will error if it doesn't find that extension. This is a fix for Power, but doesn't fix the default case. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Closes bazelbuild#9346. PiperOrigin-RevId: 271566240
Pick up the `third_party` portion of PR bazelbuild#9346 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
Pick up the `third_party` portion of PR #9346 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
The zip -d flag will error if it doesn't find that extension. This is a fix for Power, but doesn't fix the default case. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Closes bazelbuild#9346. PiperOrigin-RevId: 271566240
…ding something to delete) Build on s390x fails because the process to remove unnecessary libraries from netty was not configured for x86. As a result, zip -d failed because it had nothing to remove. This PR does two things: 1. Adds conditions for s390x to the src and third_party BUILD files, and 2. Adds a condition to the genrule so that 'zip -d' does not execute if there's nothing to do. See also Issue #9263; Pull Requests #9346 and #9945 Closes #10643. PiperOrigin-RevId: 294698707
Continuation of PR #10643 for application to third_party directory Build on s390x fails because the process to remove unnecessary libraries from netty was not configured for x86. As a result, zip -d failed because it had nothing to remove. This PR does two things: Adds conditions for s390x to the src and third_party BUILD files, and Adds a condition to the genrule so that 'zip -d' does not execute if there's nothing to do. See also Issue #9263; Pull Requests #9346 and #9945 Closes #10798. Signed-off-by: Philipp Wollermann <philwo@google.com>
The zip -d flag will error if it doesn't find that extension.
This is a fix for Power, but doesn't fix the default case.
Signed-off-by: Christy Norman christy@linux.vnet.ibm.com