-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runfiles: support space in file paths #9351
Closed
Closed
Commits on Sep 9, 2019
-
Runfiles: support space in file paths
Support space in paths of data-dependencies. The runfiles manifest remains the same for files without space in their runfiles-relative path. For files with space in their runfiles-relative path: the delimiter between runfile path and link target is now '|' instead of space. Tools and rules that consume runfiles manifests should test for a '|' delimiter, and if missing, fall back to space. This design ensures that manifest consumers keep working without having to handle '|', as long as all data-dependencies are space-free. Otherwise they break, but they would break today anyway. Fixes bazelbuild#4327 Change-Id: I37ce3b3ef2a9e92691e987588b0e6d67969a78c5
Configuration menu - View commit details
-
Copy full SHA for 46c769c - Browse repository at this point
Copy the full SHA 46c769cView commit details
Commits on Sep 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 360d4d9 - Browse repository at this point
Copy the full SHA 360d4d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1badddf - Browse repository at this point
Copy the full SHA 1badddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0b6d24 - Browse repository at this point
Copy the full SHA d0b6d24View commit details
Commits on Sep 11, 2019
-
Merge branch 'master' into gh4327
Change-Id: I1072b65ee546d37dfe969c73c76980e43234a3fe
Configuration menu - View commit details
-
Copy full SHA for e6897e7 - Browse repository at this point
Copy the full SHA e6897e7View commit details -
Fix test on Linux; use U+0001 as space replacement
Change-Id: I611454ea7d6001b97d6f3417b7331c978070fc3f
Configuration menu - View commit details
-
Copy full SHA for 4d7705f - Browse repository at this point
Copy the full SHA 4d7705fView commit details -
Change-Id: I636118c40f2c1ef6e2792e1d0ceb07aff9e30880
Configuration menu - View commit details
-
Copy full SHA for 3d7b4d0 - Browse repository at this point
Copy the full SHA 3d7b4d0View commit details
Commits on Sep 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a41182b - Browse repository at this point
Copy the full SHA a41182bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff5329b - Browse repository at this point
Copy the full SHA ff5329bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.