Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runfiles: support space in file paths #9351

Closed
wants to merge 9 commits into from

Commits on Sep 9, 2019

  1. Runfiles: support space in file paths

    Support space in paths of data-dependencies.
    
    The runfiles manifest remains the same for files
    without space in their runfiles-relative path.
    
    For files with space in their runfiles-relative
    path: the delimiter between runfile path and link
    target is now '|' instead of space. Tools and
    rules that consume runfiles manifests should test
    for a '|' delimiter, and if missing, fall back to
    space.
    
    This design ensures that manifest consumers keep
    working without having to handle '|', as long as
    all data-dependencies are space-free. Otherwise
    they break, but they would break today anyway.
    
    Fixes bazelbuild#4327
    
    Change-Id: I37ce3b3ef2a9e92691e987588b0e6d67969a78c5
    laszlocsomor committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    46c769c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Fix test on Windows

    laszlocsomor committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    360d4d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1badddf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d0b6d24 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Merge branch 'master' into gh4327

    Change-Id: I1072b65ee546d37dfe969c73c76980e43234a3fe
    laszlocsomor committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    e6897e7 View commit details
    Browse the repository at this point in the history
  2. Fix test on Linux; use U+0001 as space replacement

    Change-Id: I611454ea7d6001b97d6f3417b7331c978070fc3f
    laszlocsomor committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    4d7705f View commit details
    Browse the repository at this point in the history
  3. Move test to other file

    Change-Id: I636118c40f2c1ef6e2792e1d0ceb07aff9e30880
    laszlocsomor committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    3d7b4d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Configuration menu
    Copy the full SHA
    a41182b View commit details
    Browse the repository at this point in the history
  2. Fix test on Windows

    laszlocsomor committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    ff5329b View commit details
    Browse the repository at this point in the history