Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary URL layouts #423

Closed
jmmv opened this issue Feb 7, 2023 · 2 comments · Fixed by #427
Closed

Support arbitrary URL layouts #423

jmmv opened this issue Feb 7, 2023 · 2 comments · Fixed by #427

Comments

@jmmv
Copy link
Contributor

jmmv commented Feb 7, 2023

I'm in a situation where I have to download custom Bazel builds, but the only file hosting service I have access to imposes a weird URL layout on me. As a result, I cannot use BAZELISK_BASE_URL due to its assumptions on how the repository is laid out.

Could I suggest adding a new BAZELISK_URL_FMT variable or similar to generalize the way URLs are computed? It could take something like this:

BAZELISK_URL_FMT=https://server.example.com/my/weird/<ARCH>/layout/bazel-<RELEASE>-foo/weirder/<OS>

This new variable should conflict with at least BAZELISK_BASE_URL and result in an invalid configuration file error, because the two are incompatible.

Happy to take a stab at implementing this if the idea sounds reasonable.
@fweikert
Copy link
Member

Hey Julio,
Great to see you again! The idea sounds good to me.

@jmmv
Copy link
Contributor Author

jmmv commented Feb 15, 2023

Cool, cool. I actually wrote a patch that implements this last week but I'm clearing some hurdles before I can share it. Stay tuned!

jmmv added a commit to Snowflake-Labs/bazelisk that referenced this issue Feb 16, 2023
@jmmv
Implement support for BAZELISK_FORMAT_URL
dc33808 
This new configuration setting provides a format-like string to compute the
URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as
this is a more general concept.

Fixes bazelbuild#423.
@jmmv jmmv mentioned this issue Feb 16, 2023
Merged
@brentleyjones brentleyjones mentioned this issue Feb 28, 2023
Open
jmmv added a commit to Snowflake-Labs/bazelisk that referenced this issue Mar 20, 2023
@jmmv
Implement support for BAZELISK_FORMAT_URL
bbbdc98 
This new configuration setting provides a format-like string to compute the
URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as
this is a more general concept.

Fixes bazelbuild#423.
jmmv added a commit to Snowflake-Labs/bazelisk that referenced this issue Apr 4, 2023
@jmmv
Implement support for BAZELISK_FORMAT_URL
bbe6a46 
This new configuration setting provides a format-like string to compute the
URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as
this is a more general concept.

Fixes bazelbuild#423.
jmmv added a commit to Snowflake-Labs/bazelisk that referenced this issue Apr 5, 2023
@jmmv
Implement support for BAZELISK_FORMAT_URL
7175ca5 
This new configuration setting provides a format-like string to compute the
URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as
this is a more general concept.

Fixes bazelbuild#423.
jmmv added a commit to Snowflake-Labs/bazelisk that referenced this issue Apr 6, 2023
@jmmv
Implement support for BAZELISK_FORMAT_URL
017c0a2 
This new configuration setting provides a format-like string to compute the
URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as
this is a more general concept.

Fixes bazelbuild#423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement support for BAZELISK_FORMAT_URL Snowflake-Labs/bazelisk
2 participants
@jmmv @fweikert