GO: Return latest version from GCS that is a full release #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `latest-n` was requested, Bazelisk previously only examined the most recent version to see whether it had a release (and not just candidates). If there was no release, Bazelisk simply returned the second-to-last without checking whether that version had a release, too. Now Bazelisk checks the latest versions until it finds one with a release. Fixes #170 Progress towards #171
philwo
approved these changes
Sep 28, 2020
| _, isRelease, err := listDirectoriesInReleaseBucket(latestVersion + "/release/") | ||
| if err != nil { | ||
| return []string{}, fmt.Errorf("could not list release candidates for latest release: %v", err) | ||
| // TODO(#171): This algorithm is incorrect if version == 'latest-n' and any of the last n versions (except the last one) does not have a release yet. |
There was a problem hiding this comment.
Just for my understanding, what we would actually want to do here is to basically filter the sorted array and remove all entries for which no release version exists, right? But we don't do that, because you think it's too slow due to the number of HTTP requests?
There was a problem hiding this comment.
Yes, that's the problem. But we can work around this by specifying how many of the latest releases we need: #171
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
latest-nwas requested, Bazelisk previously only examined the most recent version to see whether it had a release (and not just candidates).If there was no release, Bazelisk simply returned the second-to-last one without checking whether that version had a release, too.
Now Bazelisk checks the latest versions until it finds one with a release.
Fixes #170
Progress towards #171