Support BAZELISK_NOJDK in Bazelisk Go. Fix #267 and #430 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
approved these changes
May 16, 2023
ql-owo-lp
force-pushed
the
nojdk
branch
2 times, most recently
from
a0030cc to
6789187
Compare
|
Unfortunately the config change is conflicting with #462 :( Sorry for the additional work |
ql-owo-lp
force-pushed
the
nojdk
branch
3 times, most recently
from
f08dcb7 to
2e52569
Compare
Let me know if any more changes are needed |
|
Hi, Is anything else needed for this PR? Appreciate if could be merged... |
|
@ql-owo-lp would you be willing to fix the conflicts on this change? |
|
This PR can be closed now that #531 is done. |
|
I'll close this in favor of #531. @ql-owo-lp , thank you for the initial work, and sorry for the review delays. |
Sec32fun32
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support BAZELISK_NOJDK in Bazelisk Go. Fix #267 and #430