Use consistent paths to bazel binaries #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
consistent-path-variables-content-digest
branch
2 times, most recently
from
395ec66
to
8cf20b6
Compare
Before this change, changing which mirror you were downloading from would change the $PATH environment variable bazel is run with, even though the bazel binaries being pointed to are identical. This can cause repository rules to invalidate and re-run. Instead, store downloaded bazels in directories keyed off of the sha256 of the bazel binary itself, and track the metadata of a mirror+version -> sha256. This avoid spurious rebuilds when only changing the URL bazelisk would use to download bazel.
illicitonion
force-pushed
the
consistent-path-variables-content-digest
branch
from
8cf20b6
to
f17149c
Compare
|
@fweikert could you take a look? Thanks! |
fweikert
approved these changes
Jun 1, 2023
|
Nice, thank you for this PR! |
|
Line 336 in b7f5c75 Bazelisk postsubmit is now failing with Any idea how to fix the test? |
meteorcloudy
added a commit
that referenced
this pull request
Nov 10, 2023
|
Looks like sourceforge dropped 6.2.0. We can switch to 6.2.1, but that will lead to the same error in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, changing which mirror you were downloading from would change the $PATH environment variable bazel is run with, even though the bazel binaries being pointed to are identical. This can cause repository rules to invalidate and re-run.
Instead, store downloaded bazels in directories keyed off of the sha256 of the bazel binary itself, and track the metadata of a mirror+version -> sha256.
This avoid spurious rebuilds when only changing the URL bazelisk would use to download bazel.